Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
CLA is now signed. This PR is ready for review when a maintainer has a chance to approve the workflows. |
|
This pull request has had no activity for 60 days, so it has been labelled If it is still wanted, a comment or a push is enough to reset the clock. Otherwise it will be closed automatically in 30 days. Nothing about this is final — a closed pull request reopens with one click, and your commits are untouched on your own branch. Maintainers: apply |
| return Agent( | ||
| name="nyc_cre_assistant", | ||
| model=Gemini( | ||
| model=os.getenv("MODEL_NAME", "gemini-3.5-flash"), |
There was a problem hiding this comment.
[MINOR] env read carries a hardcoded default (second argument is a hardcoded default); 2 occurrence(s) across 2 file(s). Defaults belong in .env.example, not in the code (contrib/python/nyc-cre-assistant/app/agent.py:53; contrib/python/nyc-cre-assistant/app/tools/bbl_address.py:35)
| NYS_DOMAIN, | ||
| DOS_ACTIVE_CORPORATIONS_DATASET, | ||
| { | ||
| "$where": f"upper(current_entity_name) = '{normalized}'", |
There was a problem hiding this comment.
[MAJOR] This is an unescaped entity name interpolated directly into a SoQL query. Can we please escape single quotes in normalized so names with apostrophes don't cause query syntax errors or injection?
| DOS_ACTIVE_CORPORATIONS_DATASET, | ||
| { | ||
| "$where": ( | ||
| f"upper(current_entity_name) like '%{normalized}%'" |
There was a problem hiding this comment.
[MAJOR] same issue as above
| ) | ||
|
|
||
| NYC_DOMAIN = "data.cityofnewyork.us" | ||
| ACRIS_LEGALS_DATASET = "8h5j-fqxa" |
There was a problem hiding this comment.
[MINOR] duplicated in find_owner.py
| } | ||
|
|
||
|
|
||
| def _map_acris_party(record: JsonRecord) -> JsonRecord: |
There was a problem hiding this comment.
[MINOR] Can we move _map_acris_party() to shared.py? It seems identical to the implementation in find_owner.py.
| "recordedDate": document.get("recordedDate"), | ||
| "recordedAmount": document.get("recordedAmount"), | ||
| "crfn": document.get("crfn"), | ||
| "lendersOrMortgagees": _party_names_by_type(document, "2"), |
There was a problem hiding this comment.
[MINOR] Can we extract "1" and "2" into named constants? It would clarify these ACRIS party type codes.
| """Fetch JSON from a public API.""" | ||
| request = Request(url, headers=headers or {}) | ||
| try: | ||
| with urlopen(request, timeout=30) as response: |
There was a problem hiding this comment.
[MINOR] extract timeout to named constant
|
There is a problem with the Antigravity CLI Hygiene PR review. Please check the action logs for details. |
|
There is a problem with the Antigravity CLI Correctness PR review. Please check the action logs for details. |
|
This pull request isn't ready for review yet. I removed the review request for Failing checks (5)
Fix the failing checks. Once everything is green I will re-request the review automatically, so there is no need to ping anyone. This is re-checked every 15 minutes. Applied by the review gate ( |
|
The repo has moved to be more of a feature display of ADK and less of a menagerie of different agents that the community has made. This is a great use case and a good implementation idea but doesn't use many features past ADK>=2.0.0 or incorporate any GCP tools to show a recipe that another user or agent can follow or learn from. |
Summary
Adds a Python ADK recipe for NYC commercial real estate public-record lookup.
The recipe demonstrates a single ADK agent using three file-based skills and
three deterministic tools to:
Validation
ruff format .ruff check .uv run pytestuv run validate contrib/python/nyc-cre-assistantuv run python .github/scripts/check_recipe_pyproject.py contrib/python/nyc-cre-assistantuv run python .github/scripts/check_env_vars.py contrib/python/nyc-cre-assistantuv lock --check