Add sparse simplex, transport, and Birkhoff projections from JAXopt #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transport/Birkhoff projections require a solver via make_solver argument.
Contributor
|
Thanks! I'd ask one of the project maintainers, perhaps @rdyro, about the desired API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have set it up so one can feed the solver for Transport/Birkhoff projections via make_solver argument. @carlosgmartin for this PR is this enough (as the tests are namesake for these) or should I only port the sparse_simplex for now?
Continuation of #1280, #1351 and #1439