chore: knip cleanup - remove unused exports and dead code#2761
Open
Myestery wants to merge 4 commits intofix/deploy-and-ephemeral-invoke-cli-argsfrom
Open
chore: knip cleanup - remove unused exports and dead code#2761Myestery wants to merge 4 commits intofix/deploy-and-ephemeral-invoke-cli-argsfrom
Myestery wants to merge 4 commits intofix/deploy-and-ephemeral-invoke-cli-argsfrom
Conversation
The log viewer's copy button was copying the empty `logs` prop instead of falling back to `title` like the display does. Also fixes pre-existing typecheck errors in test files.
…ency Ran knip --strict to identify and remove unused exports across UI components, services, types, and utilities. Removed the unused tauri-plugin-http dependency from both JS and Rust sides. Added knip.json configuration for false positives.
Rename `host` + `subdomain` fields to single `domain` field and `definition` to `definitions` in HttpApiDeployment type. Add migrateDeploymentSchema to auto-migrate legacy YAML files before deploy, deployment list, and deployment delete operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knip --strictto identify and remove unused exports, dead code, and duplicate exports across the desktop app@tauri-apps/plugin-httpdependency from JS (npm), Rust (Cargo.toml), plugin init (lib.rs), capabilities (default.json), and storybook mocks — it was never imported in TS sourceknip.jsonconfiguration to handle false positives (Modal.tsx used by stories, setup.ts used by vitest, tailwindcss-animate used in tailwind config)Test plan
npm run typecheckpassesnpm run formatpassesnpm run lint:fixpassesnpx knip --strictpasses clean