Repository navigation
Push all the scripts from the different skills in 1 tools directory - #86
Conversation
There was a problem hiding this comment.
1 issue found across 16 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="skills/paper-review/SKILL.md">
<violation number="1" location="skills/paper-review/SKILL.md:16">
P1: The installed `paper-review` plugin has no shared tools: the marketplace installs only `./paper-review`, while `papers.py` now lives in sibling directory `skills/tools`. `<tools-dir>` therefore does not exist when this skill is installed, so title lookup and random selection cannot run; bundle the shared tools in the install surface or publish one plugin containing both the skills and `skills/tools`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| This skill does not touch the repository: no edits, no commits, no PR, and it | ||
| never adds the paper to a `BIBLIOGRAPHY.md`. Its only output is the HTML file. | ||
|
|
||
| Resolve `<tools-dir>` to the absolute `skills/tools` directory in the local |
There was a problem hiding this comment.
P1: The installed paper-review plugin has no shared tools: the marketplace installs only ./paper-review, while papers.py now lives in sibling directory skills/tools. <tools-dir> therefore does not exist when this skill is installed, so title lookup and random selection cannot run; bundle the shared tools in the install surface or publish one plugin containing both the skills and skills/tools.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At skills/paper-review/SKILL.md, line 16:
<comment>The installed `paper-review` plugin has no shared tools: the marketplace installs only `./paper-review`, while `papers.py` now lives in sibling directory `skills/tools`. `<tools-dir>` therefore does not exist when this skill is installed, so title lookup and random selection cannot run; bundle the shared tools in the install surface or publish one plugin containing both the skills and `skills/tools`.</comment>
<file context>
@@ -13,6 +13,9 @@ reviewer's opinion (sections 1 and 3).
This skill does not touch the repository: no edits, no commits, no PR, and it
never adds the paper to a `BIBLIOGRAPHY.md`. Its only output is the HTML file.
+Resolve `<tools-dir>` to the absolute `skills/tools` directory in the local
+goldener-research checkout, including when this skill is installed elsewhere.
+
</file context>
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Summary by cubic
Consolidates all skill helper scripts into a single shared
skills/toolsdirectory and makes plugin installs pull in that directory, so skills no longer bundle their own private copies of the same script.<tools-dir>(found at runtime in the checkout'sskills/toolsor the installed plugin'stools/) instead of local copies, and the SKILL.md files now include instructions for discovering that path.papers.pyfromshort-paper-review;bundle_resources.py, the test suite, and the LinkedIn workflow point at the shared location, andresearchers.pyadjusts its default repo-root lookup for the shallower path.tools/is installed alongside each skill, adds a matching Codex plugin, updates packaging tests, and ignores local agent discovery configs (.agents/).Written for commit 0ae64dc. Summary will update on new commits.