Repository navigation
Make the skills more agent agnostic (trying to make claude and codex agreeing on them) - #79
Merged
Merged
Conversation
…agreeing on them)
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 15 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Yann-CV
commented
Nov 3, 2026
Yann-CV
left a comment
Contributor
Author
There was a problem hiding this comment.
Review of the agent-agnostic rewrite (head dae9fc4).
Blocking
- Merge conflicts with
main. #80 (Thunderbird signature, IMAP Date/Message-ID) has since changedskills/contact-researchers/SKILL.mdandscripts/mailbox.py(+222 lines), and the PR is nowCONFLICTING. Theconfig()refactor inmailbox.pyneeds to be redone on top of the new signature code, not resolved mechanically. - The sync skills lost their actual specification. About 5,000 lines were removed from the six
sync-*skills, and each one now delegates toreferences/sync-workflow.md, which isn't in the tree (cubic's P1, still unresolved). Beyond that one file, the skills now point to things that are defined nowhere: the "canonical bibliography format", theRESEARCHERS.mdentry format, the "shared relevance criteria", the "shared budgets", the branch/commit/PR naming, the issue-closing rules, the untrusted-issue-content rule (cubic flagged it only forsync-paper-issues, but it's missing from all six) and the write-access probe. As it stands, an agent running any of these skills has to improvise the repository's formats. Please add the reference file (andshort-paper-review'sreferences/paper-review/SKILL.md,references/targets.mdandskills/tools/bundle_resources.py) in this PR, or keep the content inline.
Other
- The PR description is empty. A short summary of the intended behavior changes would help, e.g. the dropped "non-profit" wording, the new 8-year lab window, the overridable caps and the new
configexit codes. - The descriptions in
marketplace.jsonand theSKILL.mdfrontmatter now differ for the same skill (e.g.sync-idea-issues: "deliver locally or through the authorized PR/issue workflow" vs "delivering through a PR and closing the source issues"). Pick one source of truth.
Inline comments below cover the points not already raised by cubic.
Yann-CV
had a problem deploying
to
linkedin-post
November 3, 2026 21:36 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Goldener research skills usable across agents while retaining their research criteria, repository formats, and authorized delivery behavior. Instructions describe capabilities rather than specific interaction or connector APIs; each installable skill includes the resources it needs.
skills/tools/bundle_resources.pyregenerates these resources and derives marketplace descriptions from SKILL.md frontmatter, which is the source of truth.Validation: 16 local regression tests passed; all 10 skills passed the skill-creator validator; generated-resource/catalog checks, relative references in 19 Markdown files, and
git diff --checkpassed. Tests use local fixtures and mocked mailbox/vault access; no live outreach or publishing workflows were executed.