Skip to content

Make the skills more agent agnostic (trying to make claude and codex agreeing on them) - #79

Merged
Yann-CV merged 3 commits into
mainfrom
review/agent-agnostic-skills
Nov 3, 2026
Merged

Yann-CV merged 3 commits into
mainfrom
review/agent-agnostic-skills

Conversation

@Yann-CV

@Yann-CV Yann-CV commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Make Goldener research skills usable across agents while retaining their research criteria, repository formats, and authorized delivery behavior. Instructions describe capabilities rather than specific interaction or connector APIs; each installable skill includes the resources it needs.

  • Add the shared sync contract and its six generated standalone copies. Restore explicit relevance and identity checks, bibliography/researcher formats, source trust rules, worktree handling, branch/commit/PR naming, issue completion rules, and recovery after partial delivery. Imported ideas retain the existing Question / Date / Author / Context format with escaped source text and provenance in the run record and PR.
  • Bundle the full paper-review workflow, template, and helper with short-paper-review, and add its target-format guide. skills/tools/bundle_resources.py regenerates these resources and derives marketplace descriptions from SKILL.md frontmatter, which is the source of truth.
  • Use explicit, overridable budgets: 30 author checks, 200 abstract checks, and 300 network requests by default; theme pool/seed caps are also overridable. The three-paper qualification for discovered researchers and two-level recursion remain. Unresolved namesake ambiguity can require a question, now disclosed in the researcher description.
  • For large unscoped lab lists, declare an eight-calendar-year window including the current year. Completing that window permits issue closure; the PR and issue outcome must identify the exact years and excluded older output. Explicit ranges and all-history requests override this default, and incomplete requested coverage keeps issues open.
  • Keep Goldener's established non-profit, open-source positioning. Outreach uses neutral sender wording unless the user supplies a representative role. PR researcher lookup fetches the recorded head/base commits into a scratch object store and extracts only regular root/topic research documents, rejecting unsafe paths and symlinks.
  • Fix Unicode title matching and validate explicit repository roots using the same markers as automatic discovery. Proposal reports include snapshot/retrieval provenance and explain any shortfall against the requested proposal count. Short summaries disclose AI generation by default, with the user override stated consistently in frontmatter and instructions.
  • Merge current main, preserving Thunderbird signature handling and draft Date/Message-ID headers. Mailbox config returns 0 for success, 2 for absent/partial configuration, and 1 for errors; it resolves the password once, includes the signature source, preserves missing-env-file paths, and suppresses credential/provider details.

Validation: 16 local regression tests passed; all 10 skills passed the skill-creator validator; generated-resource/catalog checks, relative references in 19 Markdown files, and git diff --check passed. Tests use local fixtures and mocked mailbox/vault access; no live outreach or publishing workflows were executed.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread skills/sync-paper-issues/SKILL.md Resolved
Comment thread skills/short-paper-review/SKILL.md Resolved
Comment thread skills/sync-idea-issues/SKILL.md Resolved
Comment thread skills/contact-researchers/SKILL.md Resolved
Comment thread skills/contact-researchers/SKILL.md Resolved
Comment thread skills/.claude-plugin/marketplace.json Resolved
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

@Yann-CV Yann-CV left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the agent-agnostic rewrite (head dae9fc4).

Blocking

  1. Merge conflicts with main. #80 (Thunderbird signature, IMAP Date/Message-ID) has since changed skills/contact-researchers/SKILL.md and scripts/mailbox.py (+222 lines), and the PR is now CONFLICTING. The config() refactor in mailbox.py needs to be redone on top of the new signature code, not resolved mechanically.
  2. The sync skills lost their actual specification. About 5,000 lines were removed from the six sync-* skills, and each one now delegates to references/sync-workflow.md, which isn't in the tree (cubic's P1, still unresolved). Beyond that one file, the skills now point to things that are defined nowhere: the "canonical bibliography format", the RESEARCHERS.md entry format, the "shared relevance criteria", the "shared budgets", the branch/commit/PR naming, the issue-closing rules, the untrusted-issue-content rule (cubic flagged it only for sync-paper-issues, but it's missing from all six) and the write-access probe. As it stands, an agent running any of these skills has to improvise the repository's formats. Please add the reference file (and short-paper-review's references/paper-review/SKILL.md, references/targets.md and skills/tools/bundle_resources.py) in this PR, or keep the content inline.

Other

  • The PR description is empty. A short summary of the intended behavior changes would help, e.g. the dropped "non-profit" wording, the new 8-year lab window, the overridable caps and the new config exit codes.
  • The descriptions in marketplace.json and the SKILL.md frontmatter now differ for the same skill (e.g. sync-idea-issues: "deliver locally or through the authorized PR/issue workflow" vs "delivering through a PR and closing the source issues"). Pick one source of truth.

Inline comments below cover the points not already raised by cubic.

Comment thread skills/sync-idea-issues/SKILL.md Resolved
Comment thread skills/sync-paper-issues/SKILL.md Resolved
Comment thread skills/sync-theme-issues/SKILL.md Resolved
Comment thread skills/sync-lab-issues/SKILL.md Resolved
Comment thread skills/sync-researcher-issues/SKILL.md Resolved
Comment thread skills/contact-researchers/SKILL.md Resolved
@Yann-CV
Yann-CV merged commit 6b47fee into main Nov 3, 2026
1 check passed
@Yann-CV
Yann-CV deleted the review/agent-agnostic-skills branch November 4, 2026 06:22

This branch had an error being deployed

1 failed deployment
linkedin-post — f200ce5c Deployed Nov 3, 2026 by Yann-CV via Draft a LinkedIn post about a research paper #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant