Skip to content

Adapt the link mention in the linkedin post content depending on the presence of paper in the PR - #61

Merged
Yann-CV merged 1 commit into
mainfrom
linkedin-trigger-line
Oct 15, 2026
Merged

Yann-CV merged 1 commit into
mainfrom
linkedin-trigger-line

Conversation

@Yann-CV

@Yann-CV Yann-CV commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

When the LinkedIn post workflow is triggered by a merged pull request, the line mentioning the pull request was always
`Added to goldener-research in: `, even when the pull request added no paper (and the post was then about a random
paper of the bibliography).

  • The `Choose the paper` step, which already compares the papers of the base and merge commits, now sets
    `TRIGGER_LINE` through `GITHUB_ENV`:
    • `Added to goldener-research in: ` when the pull request added at least one paper;
    • `Triggered by merging: ` otherwise.
  • The fixed `TRIGGER_LINE` of the job's environment is removed; the prompt and the `Check the post` step are unchanged.
  • Manual runs still get no line.

Tested by running the step's Python locally with and without an added paper, and the YAML parses.

🤖 Generated with Claude Code


Summary by cubic

When a merged pull request triggers the LinkedIn post workflow, the line mentioning the pull request now depends on whether the pull request added papers.

  • "Added to goldener-research in: <url>" when the pull request added at least one paper; "Triggered by merging: <url>" when it added none, since the post is then about a random paper of the bibliography.
  • The Choose the paper step sets TRIGGER_LINE via GITHUB_ENV, replacing the fixed value in the job environment; the prompt and Check the post step are unchanged.
  • Manual runs still get no line.

Written for commit f6f7e62. Summary will update on new commits.

View guided diff Turn on auto-fix

A merged pull request that added papers keeps "Added to goldener-research in: <url>"; one that added none now gets
"Triggered by merging: <url>", since its post is about a random paper of the bibliography.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

@Yann-CV Yann-CV added the no-post do not post a short paper review on Linkedin label Oct 15, 2026
@Yann-CV Yann-CV changed the title Word the LinkedIn post's pull request line after whether it added papers Adapt the link mention in the linkedin post content depending on the presence of paper in the PR Oct 15, 2026
@Yann-CV
Yann-CV merged commit 18e6a2b into main Oct 15, 2026
1 check passed
@Yann-CV
Yann-CV deleted the linkedin-trigger-line branch October 15, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-post do not post a short paper review on Linkedin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant