Open
Conversation
463fd48 to
6353d7e
Compare
Collaborator
|
Hi, I’m not sure whether these changes are good for the design goal without side effects.
I prefer to temporarily suspend this PR, and deliberate over it again after GodotJS (the expected features/implementation) is more complete. |
Contributor
Author
|
I'm fine with your opinion, I will maintain the patch series because I will use it, and you can merge it in the future if you want. if you have suggestion for improvement or change let me know. Best regards |
6353d7e to
e3bd382
Compare
e3bd382 to
cb945fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This patch suite add GodotJavaScript script language. JS scripts work the same as TS scripts and they share the same javascript environment, but they do not need to be compiled using "tsc", i.e. they are loaded in-place as they are.
The code are mostly shared by both ScriptLanguage, created classes are written to override names and file extensions.
Best regards