fix: replace date() with WordPress Date/Time API in 14 files

[faisalahammad]

Summary

Replace date() calls with WordPress-compliant alternatives (gmdate, wp_date, current_time) across 14 files. Remove PHPCS exclusion for WordPress.DateTime.RestrictedFunctions.date_date sniff so future violations are caught by check-cs.

Fixes 40 PCP date_date violations.

Changes

Core date class (includes/class.llms.date.php)

Before:

return date( 'd/m/Y', strtotime( $date ) );
$today = current_time( 'Y-m-d' );
$current_month = date( 'm', strtotime( $today ) );
return date( 'd.m.Y H:i:s', get_user_meta( $user_id, 'llms_last_login', true ) );

After:

return wp_date( 'd/m/Y', strtotime( $date ) );
$today = current_time( 'Y-m-d' );
$current_month = wp_date( 'm', strtotime( $today ) );
return wp_date( 'd.m.Y H:i:s', get_user_meta( $user_id, 'llms_last_login', true ) );

Why: wp_date() respects site timezone for display. gmdate() for DB storage. current_time('Y/m') for upload paths.

Voucher timestamps (includes/class.llms.voucher.php)

All date('Y-m-d H:i:s') for created_at/updated_at/redemption_date replaced with current_time('mysql').

Administative views (includes/admin/views/dashboard.php)

date(get_option('date_format'), …) changed to wp_date() for locale-aware display. Date boundaries use gmdate().

Config (phpcs.xml)

Removed the WordPress.DateTime.RestrictedFunctions.date_date exclusion that skipped this sniff project-wide. The @todo note about WP 5.3 is no longer relevant as the minimum WP version is 5.9.

Testing

1. composer check-cs -- verify project PHPCS passes with date_date sniff active
2. vendor/bin/phpcs --standard=WordPress --sniffs=WordPress.DateTime.RestrictedFunctions on modified files -- zero violations
3. php -l on all 14 modified files -- no syntax errors

[brianhogg]

Some of these changes from date() to wp_date() introduce potential off-by-one-date errors when the timezone is taken into account. Same with the switch from date() to current_time( 'mysql' ) modifies storage from UTC to local time, with no flag or indicator on which is which.

We'll need to plan this through more carefully, likely just replacing date() with gmdate() across the board. Closing for now.