Remove unnecessary FQDN in generated proxy trait adoption#573
Merged
Conversation
When the generated proxy and the trait being adopted share the same namespace, use the short (unqualified) trait name instead of the fully-qualified domain name. This makes generated proxy code cleaner and more readable. Also makes TraitGenerator consistently wrap cross-namespace names in Name\FullyQualified, matching ClassGenerator and EnumGenerator behavior. Closes #572 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TraitGeneratorconsistently wrap cross-namespace names inName\FullyQualified(was using plainName)Before
After
Files changed
src/Proxy/ClassProxyGenerator.php— namespace-aware short name for class proxysrc/Proxy/EnumProxyGenerator.php— same for enum proxysrc/Proxy/TraitProxyGenerator.php— same for trait proxysrc/Proxy/Generator/TraitGenerator.php— wrap cross-namespace names inFullyQualifiedCloses #572
Test plan
🤖 Generated with Claude Code