+[NSButton buttonWithTitle:target:action:] and friends create buttons with unexpected bezel style

[doganov]

The factory method +[NSButton buttonWithTitle:target:action:] creates buttons with NSRoundedBezelStyle bezels:

libs-gui/Source/NSButton.m

Line 94 in 1f1cd54

[button setBezelStyle: NSRoundedBezelStyle];

Apparently, the goal to match macOS AppKit, which created rounded bezel buttons. Unfortunately, this leads to major difference with macOS AppKit. On macOS, the rounded bezel button is the default, so the following two buttons look the same:

NSButton *btn1 = [NSButton new];
[btn1 setTitle: @"Dummy"];

NSButton *btn2 = [NSButton buttonWithTitle: @"Dummy" target: nil action: NULL];

On GNUstep, though, they look different.

I don't question the goal of matching macOS AppKit here. But my expectation for "matching macOS AppKit" is for the new method to be just a convenience method to create the same kind of buttons as the traditional initializer does, as in AppKit.

If the current GNUstep implementation stands, paradoxically, I'll need to introduce #ifdef GNUSTEP conditions in my codebase to match the AppKit behavior.

[fredkiefer]

Looks like somebody should extend the convenience test case to also include the normal alloc/init case and test that on MacOS. And we rather should be careful here, not to breather types of buttons. Are you interested in coming up with a proper solution here?

[doganov]

I admit, I'm not sure I follow what you mean by proper solution and what needs to be tested on macOS. So I'll just spell out my naïve understanding.

Given the current implementation:

+ (instancetype) buttonWithTitle: (NSString *)title
                          target: (id)target
                          action: (SEL)action
{
  NSButton *button = AUTORELEASE([[self alloc] initWithFrame: NSZeroRect]);

  [button setTitle: title];
  [button setTarget: target];
  [button setAction: action];
  [button setBezelStyle: NSRoundedBezelStyle];
  [button setButtonType: NSMomentaryPushInButton];
  [button sizeToFit];
  return button;
}

I think we should just kill the two lines:

  [button setBezelStyle: NSRoundedBezelStyle];
  [button setButtonType: NSMomentaryPushInButton];

...and leave those properties to be at their default values that come with the usual NSButton initializer.

The current tests still pass without change when I apply the above modification to the following methods:

• +buttonWithTitle:target:action:
• +buttonWithImage:target:action:
• +buttonWithTitle:image:target:action: