Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- e2e tests share one throwaway package: `dart pub get` and `build_runner` run once instead of once per test (33s -> 17s locally). - reflection_factory_build_test reads the isolate's sources once instead of per test (18s -> 14s). - CI: the e2e tests run in their own job, in parallel with the other VM tests (with coverage). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 14 14
Lines 6538 6538
=======================================
Hits 6116 6116
Misses 422 422
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
|
Closing: wrong target. The goal is a faster generator for consumers' builds, not this repo's own tests/CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
No changes to the library or the generator.
reflection_factory_generated_code_test.dart): both tests used to build their own throwaway package (dart pub get+build_runner, which compiles the builder first). They now share one package, built once insetUpAll, with each fixture in its ownlib/directory. The invokers fixture keeps its strictanalysis_options.yaml(strict-casts,avoid_dynamic_calls) through a nested one inlib/invokers/, so each test analyzes exactly what it did before.reflection_factory_build_test.dart: the 34 tests each calledloadIsolateSources()(reading every package's sources from disk). They're now read once and copied into each test's in-memoryTestReaderWriter.e2etests run in a newtest_vm_e2ejob, in parallel withtest_vm(dart test -x e2e, with coverage; the e2e tests run the builder in a sub process, so they add no coverage).Measured (local, 10 cores)
dart test(VM)On CI, the two e2e tests took ~110s of
test_vm's 127s test step, sequentially.Checks
dart format,dart analyze --fatal-infos --fatal-warnings: clean. VM 564 and Chrome 439 tests pass.🤖 Generated with Claude Code