Add better completion#233
Open
gnufied wants to merge 5 commits into
Open
Conversation
gnufied
force-pushed
the
add-better-completion
branch
from
4cb1266 to
d28c3b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So
omcdoes not currently offer completion for positional arguments such as:omc get <pod> <pod_name>This PR implements that. A lot of changes related to whitespace noise is because, we didn't seem to be using
gofmtstandards previously and bunch of files were using four spaces, instead of tab.gofmtuses tabs. Let me know if that is an issue.Disclaimer: Most of the completion code however was generated by Claude.