Skip to content

docs(claude): add shared-query and persisted-data change rules - #1983

Open
giladresisi wants to merge 1 commit into
stagingfrom
chore/claude-md-shared-data-rules
Open

docs(claude): add shared-query and persisted-data change rules#1983
giladresisi wants to merge 1 commit into
stagingfrom
chore/claude-md-shared-data-rules

Conversation

@giladresisi

Copy link
Copy Markdown
Collaborator

What kind of change does this PR introduce?

Docs — three new rules in CLAUDE.md.

Why was this change needed?

During the work on #1868, adding error: true to PostsRepository.getPosts was analyzed only through its calendar consumer — missing that the same query also serves GET /public/v1/posts, so the public API would have started returning the raw stored error column verbatim (including legacy rows holding full serialized workflow failures with stack traces and request payloads). The same PR also changed what Post.error persists without elevating that to an explicit decision.

The new rules make both mistakes mechanically checkable before they reach review: enumerate every consumer before widening a shared select/return shape, treat exposing a stored field to a new external surface as a data-exposure decision (including checking what legacy production rows contain), and never change persisted-column semantics silently.

Other information:

The #1868 leak was caught in review before merge; these rules are prevention for next time.

Checklist:

  • I have read the CONTRIBUTING guide.
  • I have signed the Contributor License Agreement (CLA).
  • I confirm I have not used AI to submit this PR or generate code for it.
  • I checked that there were no similar issues or PRs already open for this.
  • This PR fixes just ONE issue

🤖 Generated with Claude Code

https://claude.ai/code/session_0181SwfBoof22oiPhfveYFej

@giladresisi
giladresisi requested a review from egelhaus as a code owner August 28, 2026 02:40
@postiz-contribution postiz-contribution Bot added the contribution:approved Approved contributor label Aug 28, 2026
@strix-security

strix-security Bot commented Aug 28, 2026

Copy link
Copy Markdown

Strix Security Review

No security issues found.

Updated for 8025163.


Reviewed by Strix
Re-run review · Configure security review settings

@postiz-agent

postiz-agent Bot commented Aug 28, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution:approved Approved contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant