docs(claude): add shared-query and persisted-data change rules - #1983
Open
giladresisi wants to merge 1 commit into
Open
docs(claude): add shared-query and persisted-data change rules#1983giladresisi wants to merge 1 commit into
giladresisi wants to merge 1 commit into
Conversation
Strix Security ReviewNo security issues found. Updated for Reviewed by Strix |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Docs — three new rules in CLAUDE.md.
Why was this change needed?
During the work on #1868, adding
error: truetoPostsRepository.getPostswas analyzed only through its calendar consumer — missing that the same query also servesGET /public/v1/posts, so the public API would have started returning the raw storederrorcolumn verbatim (including legacy rows holding full serialized workflow failures with stack traces and request payloads). The same PR also changed whatPost.errorpersists without elevating that to an explicit decision.The new rules make both mistakes mechanically checkable before they reach review: enumerate every consumer before widening a shared select/return shape, treat exposing a stored field to a new external surface as a data-exposure decision (including checking what legacy production rows contain), and never change persisted-column semantics silently.
Other information:
The #1868 leak was caught in review before merge; these rules are prevention for next time.
Checklist:
🤖 Generated with Claude Code
https://claude.ai/code/session_0181SwfBoof22oiPhfveYFej