Skip to content

Rust: Resolve Self paths in type definitions #21247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
paldepind wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Rust: Resolve Self paths in type definitions #21247

paldepind wants to merge 2 commits into from
+124 −100

Conversation

@paldepind
Copy link
Contributor

@paldepind paldepind commented Feb 2, 2026 •
edited
Loading

This PR:

  • Implements path resolution for Self paths within type definitions.
  • Slightly simplifies how Self is handled by avoiding the need for getAnItemInSelfScope. By handling Self in getAChildSuccessor it's automatically accounted for in declaresDirectly and declares.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Feb 2, 2026
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2026
View reviewed changes
rust/ql/lib/codeql/rust/internal/typeinference/TypeMention.qll
result = TTypeParamTypeParameter(tp.getTypeParam())
)
class TraitMention extends TypeMentionImpl instanceof TraitItemNode {
override Type getTypeAt(TypePath typePath) {

Check warning

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@paldepind