Skip to content

Adapt interface to core's changes #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-s-a merged 2 commits into from
Nov 21, 2025
Merged

Adapt interface to core's changes #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9ed589
Adapted communicator manager
martin-s-a Nov 21, 2025
bafce6f
Removed outdated test
martin-s-a Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions src/communication/communicator_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,24 +26,9 @@ namespace py = pybind11;
void bind_communicator_manager(pybind11::module_ &m)
{
py::class_<communicator_manager>(m, "CommunicatorManager")
.def_property_readonly(
"backends",
[] (const communicator_manager &manager) -> std::vector<std::string>
{
std::vector<std::string> backends;
manager.enumerate_backends(backends);
return backends;
}
)
.def(
"create_world_communicator",
&communicator_manager::create_world_communicator,
py::arg("name"),
py::keep_alive<0, 1>()
)
.def(
"create_preferred_world_communicator",
&communicator_manager::create_preferred_world_communicator,
&communicator_manager::create_world_communicator,
py::keep_alive<0, 1>()
);

Expand Down
6 changes: 0 additions & 6 deletions tests/communication/test_communicator_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ def test_always_returns_same_communicator_manager(__setup_service_catalog):
cm2 = xmipp4.communication.get_communicator_manager(__setup_service_catalog)
assert cm1 is cm2

def test_returns_default_backends(__setup_service_catalog):
cm = xmipp4.communication.get_communicator_manager(
__setup_service_catalog
)
assert cm.backends == ['dummy']

@pytest.fixture
def __setup_service_catalog():
return xmipp4.ServiceCatalog()
Loading