fix: component improvements and missing exports#5
Merged
Conversation
- Fix Deck component: replace React.CSSProperties with Ink BoxProps, remove @ts-ignore - Fix DeckContext: create per-provider EventManager/EffectManager instances instead of shared singletons - Fix GameContext: add dispatch to useMemo dependency array for consistency - Export UnicodeCard and UnicodeCardProps from public API - CardStack: support rendering custom cards alongside standard cards - Delete dead robotCard.test.bak file - Add 8 new UnicodeCard tests (jokers, suits, rounded, edge cases) - Add 2 new CardStack tests (custom cards, mixed standard+custom)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of fixes and improvements across several components, contexts, and exports.
Changes
Bug fixes:
React.CSSPropertiesstyle prop with Ink'sBoxProps, removed@ts-ignoresuppressionDeckProvidernow creates its ownEventManagerandEffectManagerinstances instead of sharing module-level singletons — fixes event bleed between multiple providersdispatchtouseMemodependency array for consistency withDeckProviderMissing exports:
UnicodeCardandUnicodeCardPropsare now exported from the public API (src/index.tsx)Feature:
CardStacknow rendersCustomCardcomponents for non-standard cards instead of silently dropping themCleanup:
robotCard.test.bakfileTests (10 new):
rounded={false}, face-down without dimmed, 10-value cardTest results
165 tests passing, lint clean.