feat(integration): add gen_ai.conversation.id if available
#5307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ai.conversation.id`
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Release
Other
🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
+119
to
+124
| ) | ||
|
|
||
| _set_response_model_on_agent_span(agent, response_model) | ||
| update_ai_client_span(span, streaming_response, agent=agent) | ||
| finally: | ||
| span.__exit__(*sys.exc_info()) |
There was a problem hiding this comment.
Bug: The _sentry_conversation_id is not propagated to secondary agents during handoffs, causing subsequent spans for that agent to lack the conversation ID and breaking trace continuity.
Severity: HIGH
Suggested Fix
Propagate the _sentry_conversation_id to handoff agents before they are executed. This could be achieved by setting the attribute on the handoff agent object before it is used in _run_single_turn, or by storing the conversation_id in a context that persists across handoffs, ensuring all agents in the chain have access to it.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: sentry_sdk/integrations/openai_agents/patches/models.py#L119-L124
Potential issue: The `_sentry_conversation_id` attribute is set on the initial agent at
the start of an execution run. However, when this agent hands off control to a secondary
agent, the `_sentry_conversation_id` is not propagated. As a result, any subsequent
spans created for the secondary agent, such as `invoke_agent_span`, `ai_client_span`,
and `execute_tool_span`, will be missing the conversation ID. This leads to incomplete
trace data, as the spans from the secondary agent cannot be linked to the overall
conversation.
Did we get this right? 👍 / 👎 to inform future reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes https://linear.app/getsentry/issue/TET-1721/openai-agents-add-gen-aiconversationid