Skip to content

feat(service): Move to structured ServiceError #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lcian wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat(service): Move to structured ServiceError #262

lcian wants to merge 19 commits into from

Conversation

@lcian
Copy link
Member

@lcian lcian commented Jan 12, 2026 •
edited
Loading

Starts the work on Improve error handling by introducing a ServiceError that's returned by the storage backends.

Ref FS-220

@lcian
Copy link
Member Author

lcian commented Jan 12, 2026

@sentry review

@cursor
Copy link

cursor bot commented Jan 12, 2026

Skipping Bugbot: Bugbot is disabled for this repository

@lcian lcian changed the title wip feat(service): Introduce structured BackendError Jan 12, 2026
@linear
Copy link

linear bot commented Jan 12, 2026

FS-220 Improve error handling

@lcian lcian marked this pull request as ready for review January 12, 2026 13:39
@lcian lcian requested a review from a team as a code owner January 12, 2026 13:39
@lcian lcian changed the title feat(service): Introduce structured BackendError feat(service): Introduce structured ServiceError Jan 12, 2026
@lcian
Copy link
Member Author

lcian commented Jan 12, 2026

I've initially named this BackendError and my plan was to have an intermediate ServiceError wrapping this one, but I realized it doesn't make that much sense at this point, as ServiceError would not have that many variants anyways.

@lcian lcian mentioned this pull request Jan 12, 2026
Open
@lcian lcian changed the title feat(service): Introduce structured ServiceError feat(service): Move to structured ServiceError Jan 12, 2026
@lcian
improve
bc5259c 
Removed redundant comments for clarity in error types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matt-codecov matt-codecov matt-codecov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lcian @matt-codecov