fix(editor): keep the top bar usable when the window gets narrow #613
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -237,3 +237,44 @@ describe("AppMenu", () => { | |
| } | ||
| }); | ||
| }); | ||
|
|
||
| describe("EditorTopBar responsive affordances and tooltips", () => { | ||
| it("provides accessible name and title on the export button", () => { | ||
| renderTopBar("Demo Project"); | ||
| const exportBtn = screen.getByRole("button", { name: "topbar.export" }); | ||
| expect(exportBtn).toBeInTheDocument(); | ||
| expect(exportBtn).toHaveAttribute("title", "topbar.export"); | ||
| }); | ||
|
|
||
| it("provides title tooltips for mode switch tabs", () => { | ||
| renderTopBar("Demo Project"); | ||
| const tabs = screen.getAllByRole("tab"); | ||
| expect(tabs).toHaveLength(3); | ||
| expect(tabs[0]).toHaveAttribute("title", "topbar.modes.media"); | ||
| expect(tabs[1]).toHaveAttribute("title", "topbar.modes.edit"); | ||
| expect(tabs[2]).toHaveAttribute("title", "topbar.modes.rec"); | ||
| }); | ||
|
|
||
| it("provides title tooltips on the saved status indicator", () => { | ||
| renderTopBar("Demo Project"); | ||
| const savedIndicator = screen.getByTitle("topbar.saved"); | ||
| expect(savedIndicator).toBeInTheDocument(); | ||
| expect(savedIndicator).toHaveTextContent("topbar.saved"); | ||
| }); | ||
|
|
||
| it("keeps the brand trigger accessible by label and title even when text collapses", () => { | ||
| renderTopBar("Demo Project"); | ||
| const brandBtn = screen.getByRole("button", { name: "OpenScreen" }); | ||
| expect(brandBtn).toHaveAttribute("title", "OpenScreen"); | ||
| expect(brandBtn).toHaveAttribute("aria-label", "OpenScreen"); | ||
| }); | ||
|
|
||
| it("provides accessible language toggle with short code and options", () => { | ||
| renderTopBar("Demo Project"); | ||
| const langBtn = screen.getByRole("button", { name: "topbar.changeLanguage" }); | ||
| expect(langBtn).toBeInTheDocument(); | ||
| expect(langBtn).toHaveTextContent("EN"); | ||
| fireEvent.click(langBtn); | ||
| expect(screen.getByText("English")).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -140,18 +140,18 @@ export function EditorTopBar({ | |
| keeps the width of the longer label and the bar doesn't twitch every | ||
| time the document goes dirty. The inactive one is visibility:hidden, | ||
| which also takes it out of the accessibility tree. */} | ||
| <span className={styles.saved} title={dirty ? t("topbar.unsaved") : t("topbar.saved")}> | ||
| <span className={styles.savedState} data-on={!dirty}> | ||
| <span className={styles.dot} aria-hidden /> | ||
| <span className={styles.savedLabel}>{t("topbar.saved")}</span> | ||
| </span> | ||
| <span className={styles.savedState} data-on={dirty}> | ||
| <span | ||
| className={styles.dot} | ||
| aria-hidden | ||
| style={{ background: "var(--warn)", boxShadow: "0 0 0 3px var(--warn-soft)" }} | ||
| /> | ||
| <span className={styles.savedLabel}>{t("topbar.unsaved")}</span> | ||
| </span> | ||
| </span> | ||
|
|
||
|
|
@@ -162,6 +162,7 @@ export function EditorTopBar({ | |
| type="button" | ||
| role="tab" | ||
| aria-selected={mode === m.id} | ||
| title={t(m.labelKey)} | ||
| // Feeds the hidden bold copy that reserves the selected width — see | ||
| // .modeSwitch button::before. | ||
| data-label={t(m.labelKey)} | ||
|
|
@@ -190,7 +191,7 @@ export function EditorTopBar({ | |
| disabled={!canExport} | ||
| > | ||
| <Download size={15} /> | ||
| <span className={styles.exportLabel}>{t("topbar.export")}</span> | ||
| </button> | ||
| </header> | ||
| ); | ||
|
|
@@ -384,6 +385,8 @@ function AppMenu({ actions }: { actions: TopBarActions }) { | |
| className={`${styles.brand} ${styles.brandBtn}`} | ||
| aria-haspopup="menu" | ||
| aria-expanded={open} | ||
| aria-label="OpenScreen" | ||
| title="OpenScreen" | ||
| onClick={() => setOpen((v) => !v)} | ||
| > | ||
| {/* Decorative: the wordmark beside it already names the app — and, being the | ||
|
|
@@ -462,53 +465,29 @@ function LangButton() { | |
| return () => document.removeEventListener("mousedown", onDocClick); | ||
| }, [open]); | ||
| return ( | ||
| <div ref={ref} className={styles.langAnchor}> | ||
| <button | ||
| type="button" | ||
| className={`${styles.iconBtn} ${styles.langBtn}`} | ||
| onClick={() => setOpen((v) => !v)} | ||
| aria-label={t("topbar.changeLanguage")} | ||
| aria-pressed={open} | ||
| > | ||
| <Languages size={15} className={styles.langIcon} /> | ||
| {/* Fixed-width, centred: the short labels run from "EN" to "PT-BR" to | ||
| the CJK "简中", and letting the button size to them moved everything | ||
| to its right on each language change. */} | ||
| <span className={styles.langShort}>{getLocaleShort(locale)}</span> | ||
| <ChevronDown size={9} className={styles.langChevron} /> | ||
| </button> | ||
| {open ? ( | ||
| <div className={styles.langMenu}> | ||
| {getAvailableLocales().map((code) => ( | ||
| <button | ||
| key={code} | ||
| type="button" | ||
| className={styles.langMenuItem} | ||
| data-active={code === locale} | ||
| onClick={() => { | ||
| setLocale(code); | ||
| setOpen(false); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the required declaration separators.
Stylelint reports an error before both
padding-leftdeclarations. Add an empty line after the custom-property declarations at Lines 484 and 519.Also applies to: 519-519
🧰 Tools
🪛 Stylelint (17.14.0)
[error] 484-484: Expected empty line before declaration (declaration-empty-line-before)
(declaration-empty-line-before)
🤖 Prompt for AI Agents
Source: Linters/SAST tools