Conversation
timperrett
left a comment
timperrett
left a comment
There was a problem hiding this comment.
Thanks for submitting this @goedelsoup! Added a few comments for your review
| makeVault(List(vault.policies.policyName(sn, ns)), "restart", "") | ||
|
|
||
| def pulsar(img: Image, dc: Datacenter, ns: NamespaceName, unit: UnitDef, plan: Plan, sn: StackName): Partial[Id] = | ||
| canopus(img, dc, ns, unit, plan, sn) |
There was a problem hiding this comment.
This doesn't look right. See the workflow matrix: https://getnelson.io/getting-started/blueprints.html#workflows - where's the Vault support?
| val healthCheckName = "health_check_name" | ||
| val healthCheckPath = "health_check_path" | ||
| val healthCheckPort = "health_check_port" | ||
| val healthCheckInterval = "health_check_interval" |
There was a problem hiding this comment.
Update the docs for this? https://getnelson.io/documentation/blueprints.html
|
|
||
| val vaultPolicies = "vault_policies" | ||
| val vaultChangeMode = "vault_change_mode" | ||
| val vaultChangeSignal = "vault_change_signal" |
There was a problem hiding this comment.
What's this? Not familiar with it :-)
| def launch(image: Image, dc: Datacenter, ns: NamespaceName, unit: UnitDef, version: Version, plan: Plan, hash: String): IO[String] = { | ||
| val env = Render.makeEnv(image, dc, ns, unit, version, plan, hash) | ||
| val sn = StackName(unit.name, version, hash) | ||
| val env = Render.canopus(image, dc, ns, unit, plan, sn) |
There was a problem hiding this comment.
This doesn't look right - its coupling directly to the workflow?
| .traverse { | ||
| case Left(_) => IO.raiseError(new IllegalArgumentException("Internal error occured: un-hydrated blueprint passed to scheduler!")) | ||
| case Right(bp) => bp.template.pure[IO] | ||
| } >>= |
There was a problem hiding this comment.
nit: prefer the textual functions instead of the symbols
| // NOTE(timperrett): for some reason, this no longer works for consul | ||
| // despite trying a range of different things. | ||
| // .withReadyChecker(DockerReadyChecker.LogLineContains("Consul agent running!")) | ||
| .withReadyChecker(DockerReadyChecker |
* master: Expose unit name as env var (getnelson#225) Check the default elb scheme takes effect (getnelson#224) fix typos (getnelson#222) Use multiple branches Fix bug where the 'only' filter of DC targets was not being parsed (getnelson#220) LB name error message should be dynamic length (getnelson#217) Have the ability to specify an ELB as internal (getnelson#216) Fix LB naming to match the validators expectations (getnelson#215)
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
========================================
Coverage ? 56.4%
========================================
Files ? 133
Lines ? 4340
Branches ? 111
========================================
Hits ? 2448
Misses ? 1892
Partials ? 0
Continue to review full report at Codecov.
|
3 participants
No description provided.