fix(ci): attach SBOM at release-create time (immutable-releases 422)#116
Merged
Conversation
The publish workflow created the GitHub Release, then uploaded the CycloneDX SBOM as a separate `gh release upload` step. With immutable releases enabled on the repo, that follow-up upload is rejected (HTTP 422: 'Cannot upload assets to an immutable release'), failing the workflow after npm publish had already succeeded — v0.17.0 shipped to npm but its GitHub Release has no SBOM asset. Pass the SBOM to `gh release create` as a positional asset so it's sealed with the release atomically. Keep the file-guard (asset-less release if generation failed) and the idempotent already-exists branch (now honest that an immutable release can't be amended).
m1ngshum
added a commit
that referenced
this pull request
Jul 3, 2026
Bring the docs back in line with what shipped: - v0.16.0 released guard --confine (F1) — was still marked 'shipped to main, unreleased' in CLAUDE.md + docs/ROADMAP.md (3 spots). - v0.17.0 released Wave 0 (E3/B1a/E11/E9a) — mark ROADMAP-ADOPTION Wave 0 shipped. - Claude Code (D1) is now a first-class client — add it to the supported-clients list everywhere it's stated as current capability (README table, CLAUDE.md intro/positioning/adapters diagram, GUARD.md, ARCHITECTURE.md config-key note) and mark D1 shipped in ROADMAP-ADOPTION. - Fix the suggested release mapping (v0.17 was Wave 0 only; D1 rides v0.18). - CLAUDE.md: version line v0.15→v0.17, Last-updated date, +2 decisions-log rows (release+D1, and the immutable-releases SBOM gotcha from #116). Docs-only; no code change. Illustrative mermaid diagrams left as-is.
m1ngshum
added a commit
that referenced
this pull request
Jul 3, 2026
Developer-reach release: Claude Code (~/.claude.json) becomes a first-class client (D1). First release to attach the CycloneDX SBOM correctly (v0.17.0's attach step tripped over GitHub immutable releases; fixed in #116). Also folds in the confine macOS dogfood race fix (#119). Version is derived from the git tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The publish workflow's final step created the GitHub Release, then uploaded the CycloneDX SBOM in a separate
gh release upload --clobberstep. The repo has immutable releases enabled, which seals a release's assets at creation and rejects later uploads:So the v0.17.0 publish went green through
pnpm publish --provenance(the package is live on npm) and only died on the release-asset upload.Fix
Attach the SBOM as a positional asset to
gh release createso it's sealed atomically with the release. Preserves:continue-on-error),Scope
CI-only; one workflow step. No product code. Root-causes the release-pipeline break introduced with the SBOM step (#113).
Note: v0.17.0's release is already immutable and asset-less; this fixes it for v0.18.0 onward. Backfilling v0.17.0's SBOM (delete + recreate) is a separate manual step.