Repository navigation
Speed up Windows app installs and foundation checks - #5069
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Windows app test shards installed all 2,320 workspace dependencies, including unrelated mobile and desktop packages. Foundation checks also forced every lint, typecheck, and test task to rerun while every other Windows test job could reuse Windows-only cached results.
What changed
App test shards install the root tools and the transitive dependencies of
@bb/appand@bb/db; the database is required by the shared native-module check. Foundation checks now restore and save Windows-only Turbo results with the same 256 MB limit and used-entry pruning as the other Windows test jobs. Test commands and cross-platform coverage are retained. Updated the CI performance and Windows documentation.How you verified
pnpm exec turbo run test --filter=@bb/scripts -- test/ci-workflow.test.ts: passed both tests and all six Turbo tasks.git diff --checkpassed.