Skip to content

Unify web Project settings and fix compact row layout - #3329

Open
ymichael wants to merge 2 commits into
mainfrom
bb/fixer-consolidate-project-settings-routes-thr_q5dft7jrqg
Open

Unify web Project settings and fix compact row layout#3329
ymichael wants to merge 2 commits into
mainfrom
bb/fixer-consolidate-project-settings-routes-thr_q5dft7jrqg

Conversation

@ymichael

@ymichael ymichael commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

The Projects settings landing in #3301 added a complete management page, but existing sidebar, project-header, and machine links still opened the older source-only page. The duplicated implementation hid rename, defaults, project information, and deletion. Compact rows also centered icons against multiple lines and placed checkout action menus beneath the path.

What changed

Route every web Project settings entry to the existing Settings detail page and redirect legacy bookmarks with history replacement, preserving query/hash. Treat those redirects as Settings in route memory so Back to app remains usable, and recognize the new URL as an in-app link. Delete the old view, its private source row, and obsolete layout state. Preserve the Projects list/detail behavior and native mobile routes.

Align icons with row titles, put repository/path metadata below, and keep action menus in a fixed trailing column on compact web. Update the project verification recipe.

How you verified

  • Added regressions that fail before and pass after for legacy routing/history, Back to app route memory, and new-URL recognition.
  • Focused Turbo app suite: 70 tests passed; client-core suite: 260 tests passed. Relevant app/client-core typechecks and app build passed.
  • After the row-layout follow-up, reran the Projects list/detail suites and app typecheck; production worktree startup rebuilt successfully.
  • Real desktop and compact/coarse-pointer web checks: sidebar and machine entry points, legacy links, keyboard/header controls, Back to app, and no horizontal overflow. Inspected compact screenshots of both adjusted row layouts.
  • Formatting and diff checks passed. No server/daemon wire changes.

AGENT GENERATED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant