Unify web Project settings and fix compact row layout - #3329
Open
ymichael wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The Projects settings landing in #3301 added a complete management page, but existing sidebar, project-header, and machine links still opened the older source-only page. The duplicated implementation hid rename, defaults, project information, and deletion. Compact rows also centered icons against multiple lines and placed checkout action menus beneath the path.
What changed
Route every web Project settings entry to the existing Settings detail page and redirect legacy bookmarks with history replacement, preserving query/hash. Treat those redirects as Settings in route memory so Back to app remains usable, and recognize the new URL as an in-app link. Delete the old view, its private source row, and obsolete layout state. Preserve the Projects list/detail behavior and native mobile routes.
Align icons with row titles, put repository/path metadata below, and keep action menus in a fixed trailing column on compact web. Update the project verification recipe.
How you verified