Omit invalid completed reasoning durations - #3248
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Daemon event batches can give reasoning start and completion rows the same persisted timestamp. The completed-reasoning projection always formatted their difference as elapsed time, so unavailable timing data became a false zero-duration title. The verified reproduction and root-cause report is https://get-bb.github.io/reports/issues/3219.html.
What changed
Completed reasoning now includes a duration only when completion is later than start. Equal or reversed timestamps render the neutral
Thoughttitle, while truthful positive durations keep the existingThought for <duration>form.The change is contained to
@bb/thread-view. It does not change the host-daemon protocol, persisted events, CLI contract, Plugin SDK, configuration, migrations, generated files, or dependencies.How you verified
origin/main: expectedThought, receivedThought for 0ms.06aeaa994942ae7527dc49d2268c1f801e8542a0.pnpm exec turbo run test typecheck --filter=@bb/thread-viewpassed: 379 tests and typecheck.git diff --check origin/mainpassed.git diff --numstat origin/mainreports 57 changed text lines across 2 files (54 additions, 3 deletions) and no binary changes.Fixes #3219