Skip to content

Omit invalid completed reasoning durations - #3248

Open
bb-slop-cop[bot] wants to merge 1 commit into
mainfrom
slopcop/issue-3219
Open

Omit invalid completed reasoning durations#3248
bb-slop-cop[bot] wants to merge 1 commit into
mainfrom
slopcop/issue-3219

Conversation

@bb-slop-cop

@bb-slop-cop bb-slop-cop Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Human comments

What was wrong

Daemon event batches can give reasoning start and completion rows the same persisted timestamp. The completed-reasoning projection always formatted their difference as elapsed time, so unavailable timing data became a false zero-duration title. The verified reproduction and root-cause report is https://get-bb.github.io/reports/issues/3219.html.

What changed

Completed reasoning now includes a duration only when completion is later than start. Equal or reversed timestamps render the neutral Thought title, while truthful positive durations keep the existing Thought for <duration> form.

The change is contained to @bb/thread-view. It does not change the host-daemon protocol, persisted events, CLI contract, Plugin SDK, configuration, migrations, generated files, or dependencies.

How you verified

  • The focused regression failed on unchanged origin/main: expected Thought, received Thought for 0ms.
  • The same failure reproduced in a second clean checkout at 06aeaa994942ae7527dc49d2268c1f801e8542a0.
  • After the fix, the focused regression passed.
  • pnpm exec turbo run test typecheck --filter=@bb/thread-view passed: 379 tests and typecheck.
  • git diff --check origin/main passed.
  • git diff --numstat origin/main reports 57 changed text lines across 2 files (54 additions, 3 deletions) and no binary changes.

Fixes #3219

AGENT GENERATED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Completed Pi thinking can render as “Thought for 0ms”

1 participant