Allow retrying recoverable desktop startup failures - #3224
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Allow retrying recoverable desktop startup failures#3224bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Recoverable desktop startup failures rendered a static local error view with no action path back to the selected server target. The remote loader stopped after its first rejected navigation even though the existing target application flow could perform the required reconnect or reauthentication. The direct reproduction and root-cause report is https://get-bb.github.io/reports/issues/3223.html.
What changed
Startup errors now carry an explicit retryable flag. Recoverable remote-load, Connect-authentication, and local-attach failures render a Try again button, while fatal process, port-conflict, and shutdown errors remain non-retryable. The preload sends a fixed payload-free IPC event; the main process validates its payload, sender window, and local-view URL before showing the loading state and reapplying the selected target. This changes no host wire protocol, CLI, configuration, dependency, or public plugin API.
How you verified
pnpm exec turbo run typecheck --filter=@bb/desktoppnpm exec turbo run test --filter=@bb/desktop— 39 files passed, 294 tests passed, 1 skipped.pnpm exec turbo run build --filter=@bb/desktoppnpm exec oxfmt --checkon all five changed files.BUTTONlabeled Try again.git diff --checkFixes #3223