fix generated plugin name in scrape directory listing#280
Open
schplurtz wants to merge 1 commit intogeoserver:masterfrom
Open
fix generated plugin name in scrape directory listing#280schplurtz wants to merge 1 commit intogeoserver:masterfrom
schplurtz wants to merge 1 commit intogeoserver:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When downloading plugins, install-extensions.sh generates a sed regexp to extract the plugin filename from the http listing when it has to guess the real filename.
To do that, among other things, it adds
'-plugin\\.zip'to the extension name.Since this is between simple quotes, there is no need to escape the
\itself. and thecorrect form is
'-plugin\.zip'Without this PR, the script fails to match, say,
geoserver-2.28-SNAPSHOT-pluginname-plugin.zipagainst the wrong"{EXTENSION_REGEX_ESCAPED}"'-plugin\\.zip'regexp.