fix: cleanup lints #260
Merged
fix: cleanup lints #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
approved these changes
Dec 12, 2025
Member
|
Can you also drop that |
Contributor
The `Error::FeatureHasNoGeometry` variant contains the `FeatureType`, which drastically increases the total size of the returned enum. This has been boxed to 1. fix the lint 2. decrease the width of the type
Changing an enums private associated data is not "possibly breaking" in any sane world. Also: include GH links
michaelkirk
force-pushed
the
cleanup-lints
branch
from
7bf0b20 to
3979292
Compare
michaelkirk
reviewed
Jan 6, 2026
| * Fix `geo_rect_conversion_test` to conform to the correctly-wound `Polygon` output from `geo_types::geometry::Rect.to_polygon` | ||
| * See https://github.com/georust/geojson/issues/257 | ||
| * Potentially breaking: Box `Error::FeatureHasNoGeometry` inner type (`Box<Feature>`). This decreases the size of `Error` from 200 to 48. | ||
| * Decreased the size of the `Error` enum from 200 to 48. |
Member
There was a problem hiding this comment.
Note, I tweaked the ChangeLog entry - I can't see how this would be potentially breaking in the semver sense (tho maybe in the https://www.xkcd.com/1172/ sense).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Error::FeatureHasNoGeometryto wrap aBox<Feature>instead of aFeature. This reduces the size of the enum from 200 to 48.