Open
Conversation
Issue: When starting the mapviewer with an edit link for a KML that was deleted, the drawing module is open and can't save to a new KML as the presence of the initial admin ID is interfering with that function. Fix: We now ignore the admin ID and display an error when someone is trying to load a KML that was deleted. Also: We altered the structure of messages a bit so that the same error given by the same source is not shown, but the same error from a different source would be displayed Also Also : We added some tests to check that the message equality function was working correctly. Also Also Also : We added an acknowledgement system which stops the same source from sending the same errors multiple times
- Issue: With the extra parameters `isAcknowledged` and `sourceId` in the messages, we could end up with disgracious instantiation with empty parameters just to add the last one. - Fix: We Refactor the messages to accept objects as parameters
web-mapviewer
|
||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1895-stop-editing-nonexistent-kmls
|
| Run status |
|
| Run duration | 06m 49s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
259
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/tests-e2e/drawing.cy.js • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup |
Test Replay
Screenshots
|
|
ltkum
force-pushed
the
fix-PB-1895-stop-editing-nonexistent-kmls
branch
6 times, most recently
from
0c80955 to
f8dad09
Compare
PB-1895: resolve issue with tests failing - Issue: The updateLayers mutation was not present in the watched mutations. for some reason, it worked fine outside of the test environments, but the test environment was not pleased at all - Fix : We added the mutation watcher where it belongs :)
ltkum
force-pushed
the
fix-PB-1895-stop-editing-nonexistent-kmls
branch
from
9af89cb to
db8af5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link