test: add hook ordering regression coverage#1113
Merged
psschwei merged 1 commit intoMay 22, 2026
Merged
Conversation
psschwei
reviewed
May 22, 2026
Member
psschwei
left a comment
There was a problem hiding this comment.
Thanks for the PR @tatakaisun !
Quick note: we recently added the DCO bot to this repo, and as an unfortunate consequence any PR opened before that gets blocked by it.
To kick the bot and get it to run, could you send a new commit:
git commit --amend --no-edit
git push --force-with-lease
2444716 to
97fe958
Compare
Contributor
Author
|
Thanks for the heads up! I’ll amend the commit and push an updated revision to retrigger the DCO bot. |
Member
|
looks like you're failing the linter |
Add regression coverage for hook call-site ordering and payload mutation before downstream processing. Apply session_pre_init model_id mutations when constructing the backend. Assisted-by: OpenAI Codex Signed-off-by: tatakaisun <tatakaisun@users.noreply.github.com>
97fe958 to
90063bc
Compare
Contributor
Author
|
Thanks for the heads-up. I pushed a formatter-only update for the failing lint check. No logic changes were made. |
Merged
via the queue into
generative-computing:main
with commit May 22, 2026
0c03876
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes #1000
Description
Add regression coverage for hook call-site ordering and payload mutation before downstream processing.
This PR also applies
session_pre_initmodel_idmutations when constructing the backend, so the hook-mutatedmodel_id_stris passed to the backend constructor.Summary
generation_pre_callmutations are applied before backend generation.session_pre_initmutations are applied before backend construction.start_session()to pass the hook-mutatedmodel_id_strto the backend constructor.Testing
Manual checks:
git diff --checkpassed.uvis not available on PATH.Attribution
Assisted-by: OpenAI Codex
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.