Suggestion to make your PID-code easier to use as a library#1
Open
rpoisel wants to merge 1 commit intogeekfactory:masterfrom
Open
Suggestion to make your PID-code easier to use as a library#1rpoisel wants to merge 1 commit intogeekfactory:masterfrom
rpoisel wants to merge 1 commit intogeekfactory:masterfrom
Conversation
0eb7cb0 to
1826d81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ruben,
thanks for publishing your PID-library! It seems to be very useful to me.
This pull-request is merely a suggestion on how to make your code easier to use as a library. Instead of pulling other code (e. g. examples) in as git submodules, I would do it the other way round: using this git repository as a submodule somewhere else (e. g. a git repository with examples using this library).
Furthermore, I extracted the tick-handling functions so that it is possible as a user of the library, to provide your own implementation. This is a requirement in my case.
Please don't hesitate to get in touch with me in case you need any further information or in case you have any other suggestion.
Rainer