Skip to content

CLI args#24

Open
BrandonLMorris wants to merge 4 commits into
geek-ai:masterfrom
BrandonLMorris:cli-args
Open

CLI args#24
BrandonLMorris wants to merge 4 commits into
geek-ai:masterfrom
BrandonLMorris:cli-args

Conversation

@BrandonLMorris

Copy link
Copy Markdown

Motivation

Out of the box, LeakGAN does not work when specified through main.py. Instead, an error occurs that TensorFlow flags doesn't know how to parse argument 'g'. This is due to the fact that main.py parses arguments with getopt, but the LeakGAN constructor uses tf.app.flags.

Changes

To get LeakGAN to work properly, I modified main.py to also utilize tf.app.flags. Since these flags are intended to be global and distributed, it's perfectly legal to have flags specified in different parts of the system (i.e. LeakGAN specific args only in the LeakGAN constructor). The overall functionality is identical, with the exception that main.py args need to use their longform version (e.g. --gan_type instead of just -g).

Additionally, I factored out the definitions of the test_file, oracle_file, and generator_file to the Gan class (since they were used by every GAN type), and made them able to be specified by CLI args as well.

@hija

hija commented Nov 29, 2018

Copy link
Copy Markdown

Additionally, this fixes a bug in the current implementation, in which the -h command states, that you should use "-t realdata", while it's "-t real" instead.

@un1crom un1crom left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would love for project maintainers/owners to accept these changes. i am happy to!

@liyzcj

liyzcj commented May 7, 2019

Copy link
Copy Markdown

the args defined in leakGan's constructer can not be use as this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants