Conversation
leocassarani
reviewed
Dec 1, 2025
| }, | ||
| { | ||
| name: "heap-dump", | ||
| short: "writes the results of debug.WriteHeapDump to a file.", |
Member
There was a problem hiding this comment.
All the other shorts are capitalised
Suggested change
| short: "writes the results of debug.WriteHeapDump to a file.", | |
| short: "Writes the results of debug.WriteHeapDump to a file.", |
| } | ||
| fmt.Fprintf(conn, "New GC percent set to %v. Previous value was %v.\n", perc, debug.SetGCPercent(int(perc))) | ||
| case signal.WriteHeapDump: | ||
| fc, ok := conn.(fileConn) |
Member
There was a problem hiding this comment.
What guarantees that you can perform this cast?
Author
There was a problem hiding this comment.
It's implemented by both IPConn and UnixConn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.