Repository navigation
Include vendor-merge-into relationships in combined views - #59
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b643ce73ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "canonical-of", | ||
| "equivalent-to", | ||
| "renamed-to", | ||
| "vendor-merge-into", |
There was a problem hiding this comment.
When a product-level vendor-merge-into link reaches a product whose vendor participates in another merge, _collect_related_products_for_combined_view does not revisit vendor relationships after adding that product. For example, with product A → product B and B's vendor → vendor C, opening A omits the same-token product under C, while opening B or C includes all three. This makes the newly supported merge chains endpoint-dependent; the vendor and product traversals need to feed each other until no new records are found.
Useful? React with 👍 / 👎.
Approved
vendor-merge-intorelationships describe vendor/product normalization, but combined views omitted their records. Include this type in the shared relationship set so vendor product lists, product CPE lists, and graph membership follow merge links in either direction and through chains. This builds on the merged rename support in #58.Keep
superseded-byandderived-fromexcluded: replacement and provenance do not establish a shared product identity. Document the eligible types and this distinction in the README and code.Validation: full pytest suite — 79 passed. Extended regression tests reproduce the merge omission before the fix and cover vendor/product merge chains from both ends, CPE aggregation, graph membership, unrelated product tokens, and exclusion of replacement/provenance links while keeping them visible in the graph.