Skip to content

Keep large Pivotick graph layouts responsive - #55

Merged
adulau merged 1 commit into
mainfrom
codex/graph-worker-layout
Oct 13, 2026
Merged

adulau merged 1 commit into
mainfrom
codex/graph-worker-layout

Conversation

@adulau

@adulau adulau commented Oct 13, 2026

Copy link
Copy Markdown
Member

Large graphs introduced in #54 run force-layout warmup synchronously on the browser's main thread, which can freeze input and rendering. This follow-up addresses Codex's review feedback.

Enable Pivotick's embedded simulation worker. Configure one warmup tick, a 250 ms cooldown, and faster alpha decay so the main-thread fallback remains short when browser policy blocks workers. Alpha decay also limits v2.0.1's separate cooling stage; reducing warmup ticks alone would leave that stage running. Update the vendored-asset documentation to describe the worker and fallback behavior.

Validation:

  • Full pytest suite: 71 passed.
  • Chromium with the actual bundle and a 200-node/400-edge graph at 4× CPU throttling: verified worker completion, rendering, record inspection, theme switching, and fit controls; repeated with CSP blocking workers to verify fallback.
  • In that run, the longest measured browser timer gap decreased from 3.48 s to 0.86 s with the worker (0.92 s with workers blocked). Fallback execution decreased from 1.80 s to 0.31 s. These are measurements from the test environment, including rendering work.
  • Existing Chromium smoke checks passed for lazy loading, safe labels, selection, zoom/fit, themes, reopening, mobile resizing, and retry.
  • JavaScript syntax and whitespace checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T05:19:45.701157Z 3e9a8b8 PR opened
🔒 Security Review ✅ Completed 2026-10-13T05:19:21.890137Z 3e9a8b8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@adulau
adulau merged commit 6877f16 into main Oct 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant