Fixes #121, removes code that doesn't do anything #122
+1
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `<div>` has no attribute called `"width"` - I believe `overflow:auto` is better than `overflow:scroll`, because it doesn't display the scroll bars if they're not necessary - Removed `display:none` because obviously useless (it's removed by the JS)
- First removed line fixes gbdev#121 (it constantly evaluates to 0) - Second removed line is invalid code and does nothing at all - Third removed line is only useful because the initial value in `index.html` is useless (I removed it in my other commit to this patch)
ResizeObserver became useless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Removing the write to
displayproperty fromgfx-editor.jsrequires thatindex.htmlbe merged as well.(Using a very big tilemap (that is displayed 128px wide and extends indefinitely in height) still clips off and hides the command line output. No change here.)