Skip to content

client connection issues - #192

Merged
vladimir-ea merged 16 commits into
mainfrom
ve/lh_issues
Aug 24, 2026
Merged

client connection issues#192
vladimir-ea merged 16 commits into
mainfrom
ve/lh_issues

Conversation

@vladimir-ea

Copy link
Copy Markdown
Collaborator

a set of fixes from debugging client connection issues (specifically lighthouse):

  • tracking of rpc request outcomes
  • fix ByRoot rpc requests (previously not handled)
  • monotonically increasing ENR seq across restarts
  • advertise fake tcp support in ENR (otherwise Lighthouse will not call us)
  • stuck streams and stream timeouts
  • gossip mesh management: reduce mesh churn
  • additional surfer metrics: per client counts, mark inbound connections

@vladimir-ea

Copy link
Copy Markdown
Collaborator Author

@clanky-gattaca review

@clanky-gattaca

clanky-gattaca commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

🤖 PR review

Large P2P/gossip reliability PR: QUIC transport keep-alive + idle timeout, stream setup/inbound-RPC idle timeouts with reset-based teardown, goodbye-before-close linger, a hard inbound connection cap, over-population trimming via TooManyPeers goodbyes, a fix for DataColumnsByRootRequest SSZ parsing (list-of-identifiers, not a bare identifier), a tcache commit fix for by-root request bodies, and P7/score-gate retuning. The peer-manager gossip domain is split into manager/gossip.rs (mostly a move, with real behaviour changes: no d_high gate on remote grafts, deterministic score-ordered mesh trimming, quick-prune backoff escalation, P5-excluded gossip gate). The functional fixes look sound and are well tested; the main thing I'd hold on is the 32× bump of the per-gossip-stream outbound ring, which multiplies to ~1 GiB of eagerly-allocated heap at the new connection cap.

Blocking (1)

  • crates/network/src/p2p/quic/peer.rs:687OutBuffer::new eagerly allocates vec![None; len], so 32768 slots of Option<AcquiredRead> (~32 B) is ~1 MiB per gossip stream. Both the inbound and outbound gossipsub stream get one, and max_connections is now 600 (max_priority_peers 500 × 1.2), so this goes from ~38 MiB to ~1.2 GiB of resident heap at steady state.

8 inline comment(s) on the diff.


opus · medium effort · 365s

Re-run — tick an effort:

  • low
  • medium
  • high

@clanky-gattaca clanky-gattaca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline notes from the review comment on this PR.

Comment thread crates/peer/src/manager.rs Outdated
Comment thread crates/network/src/p2p/quic/peer.rs Outdated
Comment thread crates/storage/src/store.rs
Comment thread crates/config/src/lib.rs
Comment thread crates/config/src/lib.rs
Comment thread crates/network/src/p2p/quic/peer.rs Outdated
Comment thread crates/network/src/p2p/quic/peer.rs
Comment thread crates/network/src/p2p/quic/peer.rs
Comment thread crates/network/src/p2p/quic/peer.rs Outdated
Comment thread crates/config/src/lib.rs

@clanky-gattaca clanky-gattaca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline notes from the review comment on this PR.

Comment thread crates/network/src/p2p/quic/peer.rs Outdated
Comment thread crates/peer/src/manager.rs
Comment thread crates/network/src/p2p/quic/peer.rs Outdated
Comment thread crates/config/src/lib.rs
Comment thread crates/network/src/p2p/quic/peer.rs Outdated
Comment thread crates/network/src/p2p/quic/peer.rs

@clanky-gattaca clanky-gattaca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline notes from the review comment on this PR.

Comment thread crates/network/src/p2p/quic/peer.rs
Comment thread crates/peer/src/manager.rs
Comment thread crates/network/src/tile.rs Outdated
Comment thread crates/network/src/p2p/quic/peer.rs Outdated
Comment thread crates/config/src/lib.rs
Comment thread crates/peer/src/manager.rs
Comment thread crates/peer/src/state.rs
Comment thread crates/network/src/p2p/quic/peer.rs
@vladimir-ea
vladimir-ea merged commit aba2e37 into main Aug 24, 2026
3 checks passed
@vladimir-ea
vladimir-ea deleted the ve/lh_issues branch August 24, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants