Fix early termination of strategic form QRE on small probabilities.#817
Merged
Fix early termination of strategic form QRE on small probabilities.#817
Conversation
An earlier refactoring introduced a round-trip whereby the equation
system for logit QRE in the strategic form is expressed
in log-probabilities, but when log-probs are used in
the calculation it is via first exponentiating and taking logs.
The effect of this is that very small probabilities (<10^{-300} or so) get truncated to zero, which then gives a NaN when converting
back to log-probs.
This corrects this regression to retain log probabilities as computed by
the path-following.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An earlier refactoring introduced a round-trip whereby the equation system for logit QRE in the strategic form is expressed in log-probabilities, but when log-probs are used in the calculation it is via first exponentiating and taking logs.
The effect of this is that very small probabilities (<10^{-300} or so) get truncated to zero, which then gives a NaN when converting back to log-probs.
This corrects this regression to retain log probabilities as computed by the path-following.