Skip to content

fix(pr-craft): state a performed manual check once in a rewritten body - #12

Merged
galligan merged 1 commit into
mainfrom
fix/skills/pr-craft-ran-line-review
Nov 11, 2026
Merged

galligan merged 1 commit into
mainfrom
fix/skills/pr-craft-ran-line-review

Conversation

@galligan

@galligan galligan commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Fixes a rewritten PR body listing a performed manual check twice: once on the Ran: line and again as a reviewer step. Only that one pr-craft rule changes.

Related to #11

Context

When pr-craft rewrites an existing PR body, a manual check the author performed, such as "clicked Save and saw success", stays on the Ran: line. The rule also lets the agent offer the same check as a reviewer step, with no criterion for when. A body that does so states the check twice, against the rewrite rules to state each fact once and not outgrow the original.

Changes

  • A performed manual check stays only on the Ran: line with its result, in .skillset/skills/pr-craft/SKILL.md. The Ran: line already names the action, so a reviewer can repeat it.

Verify

  • Open ## Existing PRs in skills/pr-craft/SKILL.md → the manual-check rule ends with "Do not also add it as a reviewer step."
  • Ran: a scoped Redliner review of .skillset/skills/pr-craft/SKILL.md, with the generated skills/pr-craft/SKILL.md and references/examples.md as context → one low-severity finding, fixed here; validate.py and consolidate.py pass. bun run build, bun run check, bun run check:changes --since origin/main, bun run skillset check --only outputs, and git diff --check, all pass. Not verified: a rewrite of a real PR body under the new rule.

Open items

  • Question (reviewer): Redliner marks this a decision because it removes the step-form entry. If a step is worth the repetition, the alternative is to allow it only when the body stays within the original's length.

Devin Review

A rewrite kept a performed manual check on the Ran line and could also offer it as a reviewer step, stating the check twice. A scoped Redliner review of the canonical source and generated skill found this one issue.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T19:06:35.335386Z 43d2a78 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@galligan
galligan merged commit df56d4a into main Nov 11, 2026
3 checks passed
@linear-code

linear-code Bot commented Nov 11, 2026

Copy link
Copy Markdown

SET-840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant