Repository navigation
fix(pr-craft): state a performed manual check once in a rewritten body - #12
Merged
Merged
Conversation
A rewrite kept a performed manual check on the Ran line and could also offer it as a reviewer step, stating the check twice. A scoped Redliner review of the canonical source and generated skill found this one issue.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a rewritten PR body listing a performed manual check twice: once on the
Ran:line and again as a reviewer step. Only that onepr-craftrule changes.Related to #11
Context
When
pr-craftrewrites an existing PR body, a manual check the author performed, such as "clicked Save and saw success", stays on theRan:line. The rule also lets the agent offer the same check as a reviewer step, with no criterion for when. A body that does so states the check twice, against the rewrite rules to state each fact once and not outgrow the original.Changes
Ran:line with its result, in.skillset/skills/pr-craft/SKILL.md. TheRan:line already names the action, so a reviewer can repeat it.Verify
## Existing PRsinskills/pr-craft/SKILL.md→ the manual-check rule ends with "Do not also add it as a reviewer step.".skillset/skills/pr-craft/SKILL.md, with the generatedskills/pr-craft/SKILL.mdandreferences/examples.mdas context → one low-severity finding, fixed here;validate.pyandconsolidate.pypass.bun run build,bun run check,bun run check:changes --since origin/main,bun run skillset check --only outputs, andgit diff --check, all pass. Not verified: a rewrite of a real PR body under the new rule.Open items