Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .skillset/changes/7a9d8486c8a9.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Keep a performed manual check on the Ran line when rewriting a PR body, instead of turning it into a reviewer step.

Bump: patch
Scope: skill:pr-craft
4 changes: 4 additions & 0 deletions .skillset/changes/ledger.jsonl
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,7 @@
{"createdAt":"2026-11-11T18:12:11.116Z","id":"evt-cfee1a781660b715","payload":{"reasonId":"c70cafeb3a81","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:0aa43efa9ec684aac54c0b57337388874068d6e3845cfb0113bc19aa53a917a7"}]},"schemaVersion":1,"type":"change.covered"}
{"createdAt":"2026-11-11T18:13:46.213Z","id":"evt-52199bd60a936df6","payload":{"reasonId":"5124e78bc3c1","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:fdeea6de72c14be93d2ba9555133af51bf7378321b3459d1c20124db2fb607c8"}]},"schemaVersion":1,"type":"change.covered"}
{"createdAt":"2026-11-11T18:13:46.213Z","id":"evt-773b76bd44b73d0b","payload":{"reasonId":"c70cafeb3a81","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:fdeea6de72c14be93d2ba9555133af51bf7378321b3459d1c20124db2fb607c8"}]},"schemaVersion":1,"type":"change.covered"}
{"createdAt":"2026-11-11T18:19:00.086Z","id":"evt-9c395950bb749603","payload":{"bump":"patch","path":".skillset/changes/7a9d8486c8a9.md","reason":"Keep a performed manual check on the Ran line when rewriting a PR body, instead of turning it into a reviewer step.","reasonId":"7a9d8486c8a9","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:2aa868811cb850514c53a72d5a235e15451047d5994e5ae44829b95957aa4057"}]},"schemaVersion":1,"type":"reason.created"}
{"createdAt":"2026-11-11T18:19:00.086Z","id":"evt-83ce69dedbf202b9","payload":{"reasonId":"7a9d8486c8a9","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:2aa868811cb850514c53a72d5a235e15451047d5994e5ae44829b95957aa4057"}]},"schemaVersion":1,"type":"change.covered"}
{"createdAt":"2026-11-11T18:19:00.655Z","id":"evt-c6d9e62fbbe73c3c","payload":{"reasonId":"5124e78bc3c1","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:2aa868811cb850514c53a72d5a235e15451047d5994e5ae44829b95957aa4057"}]},"schemaVersion":1,"type":"change.covered"}
{"createdAt":"2026-11-11T18:19:00.655Z","id":"evt-d7ab7cdf13378471","payload":{"reasonId":"c70cafeb3a81","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:2aa868811cb850514c53a72d5a235e15451047d5994e5ae44829b95957aa4057"}]},"schemaVersion":1,"type":"change.covered"}
3 changes: 2 additions & 1 deletion .skillset/skills/pr-craft/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ If all of the following hold, rewrite the PR body into this shape:

- Keep every fact a reviewer needs. Below the opening paragraph, state each fact once, in the section that owns it. Drop only what `### Leave out` lists.
- Restate each verification claim in this skill's form: the command or check, and its result. Treat the original's claims as observed, and do not re-run the checks.
- If a verification claim names neither a command nor an action a reviewer could repeat, keep the claim on the `Ran:` line and add "command not stated". Do not invent a command. A manual check that names its action is carried over as a step.
- If a verification claim names neither a command nor an action a reviewer could repeat, keep the claim on the `Ran:` line and add "command not stated". Do not invent a command.
- If a verification claim is a manual check that names its action, keep it on the `Ran:` line with its result. It can also be offered as a reviewer step.
Comment thread
galligan marked this conversation as resolved.
Resolved
Comment thread
galligan marked this conversation as resolved.
Resolved
- Do not mention the rewrite, the previous body, or what was not re-run.
- Do not make the body longer than the original. Exception: if the original has no content for the opening paragraph, Context, Changes, or Verify, add only that content.
- If the body names a tracker issue, move the issue to the link line. If the body does not say how the PR relates to the issue, use `Related to`. Do not guess `Closes`.
Expand Down
3 changes: 2 additions & 1 deletion skills/pr-craft/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,8 @@ If all of the following hold, rewrite the PR body into this shape:

- Keep every fact a reviewer needs. Below the opening paragraph, state each fact once, in the section that owns it. Drop only what `### Leave out` lists.
- Restate each verification claim in this skill's form: the command or check, and its result. Treat the original's claims as observed, and do not re-run the checks.
- If a verification claim names neither a command nor an action a reviewer could repeat, keep the claim on the `Ran:` line and add "command not stated". Do not invent a command. A manual check that names its action is carried over as a step.
- If a verification claim names neither a command nor an action a reviewer could repeat, keep the claim on the `Ran:` line and add "command not stated". Do not invent a command.
- If a verification claim is a manual check that names its action, keep it on the `Ran:` line with its result. It can also be offered as a reviewer step.
- Do not mention the rewrite, the previous body, or what was not re-run.
- Do not make the body longer than the original. Exception: if the original has no content for the opening paragraph, Context, Changes, or Verify, add only that content.
- If the body names a tracker issue, move the issue to the link line. If the body does not say how the PR relates to the issue, use `Related to`. Do not guess `Closes`.
Expand Down
6 changes: 3 additions & 3 deletions skills/skillset.lock
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@
],
"kind": "standalone-skill",
"name": "pr-craft",
"outputHash": "sha256:b02e85bb2df1fe2d88cc627ab3cddf9c0fbda194d4c63ea78dd4333a3b32deec",
"outputHash": "sha256:425b168dc16e8da8cc155a1870c7128979431110eb3cf590e81ce5f416b85863",
"outputPath": "pr-craft/SKILL.md",
"sourceHash": "sha256:6edc627855c0b6650175d67b485330a0ca69a1569d958ea0c1719fc8d85b939b",
"sourceHash": "sha256:ca07f8e1810f188b9ef0e5722be493eb0d5143c95c45f60bffe0c9530af57aac",
"sourcePath": ".skillset/skills/pr-craft/SKILL.md",
"version": "0.1.0"
},
Expand Down Expand Up @@ -137,7 +137,7 @@
}
],
"outputRoot": "skills",
"provenanceHash": "sha256:aeb9de9d1f893b937c2053bd0b9b55d068dfad1cffa30e74b52f6428cef473e9",
"provenanceHash": "sha256:46485aa56997ce47069f8bcc747c605573ea9483c579694b176da2f41dc66663",
"renderResults": [
{
"destination": "skill",
Expand Down
Loading