Repository navigation
fix(pr-craft): open with impact, and tighten body rewrites #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4e573e7
fix(pr-craft): open with impact, and tighten body rewrites
galligan 441b88e
chore(pr-craft): refresh earlier change evidence
galligan 35b3bff
fix(pr-craft): resolve conflicts between the new and existing rules
galligan 1ca2fdf
fix(pr-craft): mark a carried-over claim that names no command
galligan 0da2b44
fix(pr-craft): keep manual checks out of the command-not-stated rule
galligan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Replace the scope line with an opening paragraph that states what the change does and what it affects, without diff counts. Tighten the rules for rewriting an existing PR body, and write American English by default. | ||
|
|
||
| Bump: patch | ||
| Scope: skill:pr-craft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Completed manual checks become reviewer instructions
When a body says someone clicked Save and saw success,
pr-craftmoves that observed check to a reviewer step. TheRan:line then omits the manual check, so readers cannot tell it was performed.Learn more
The Verify section distinguishes repeatable reviewer steps from checks the author already performed. This instruction moves a reported manual check into a step, where its result becomes an expectation instead of an observed result. The Verify format assigns performed checks and results to
Ran:. The body template makes the same distinction.Example: An existing body says, "Clicked Save and confirmed a success toast appeared." The rewrite lists "Click Save → success toast appears" as a step, but does not list the completed check under
Ran:. A reviewer loses evidence that Save was already checked.Recommended fix: Preserve performed manual checks and their observed results on
Ran:while also giving the reviewer a repeatable step when useful. Clarify how to avoid duplicating the same fact across the two lines.Was this helpful? React with 👍 or 👎 to provide feedback.