KAN-967 fix(mcp): set_board_sort echoes the resolved value, not null - #456
Open
fulsomenko wants to merge 2 commits into
Open
KAN-967 fix(mcp): set_board_sort echoes the resolved value, not null#456fulsomenko wants to merge 2 commits into
fulsomenko wants to merge 2 commits into
Conversation
The tool echoed the raw request, so an omitted dimension reported null even though set_board_sort resolved and persisted a concrete value. McpContext:: set_board_sort now returns the resolved (field, order) pair and the tool echoes it, matching the CLI.
fulsomenko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (v0.8.0 bug-hunt, epic KAN-960)
set_board_sort {"sort":"name"}(order omitted) persisted a concrete order to disk but the JSON response reportedboard_sort_order: nullbecause it echoed the raw request (order.map(...)) rather than the resolved value. The CLI reports the resolved pair, so the two surfaces disagreed.Fix
McpContext::set_board_sortnow returns the resolved(field, order)pair (it already computed it to persist), and the tool echoes that. An omitted dimension is reported concretely.Test
MCP integration:
set_board_sortwithorderomitted echoes a concreteboard_sort_orderstring (wasnullbefore). mcp suite green; clippy -D + fmt clean.