This repository was archived by the owner on Sep 3, 2024. It is now read-only.
Allow s3 logging from aws_s3_bucket_logging#421
Open
pguinard-public-com wants to merge 1 commit intofugue:masterfrom
Open
Allow s3 logging from aws_s3_bucket_logging#421pguinard-public-com wants to merge 1 commit intofugue:masterfrom
pguinard-public-com wants to merge 1 commit intofugue:masterfrom
Conversation
56fff1d to
62fa1d9
Compare
62fa1d9 to
1bc298e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374
Sample from that pull request which also matches the code we have provided in tests:
Fixed behavior:
Original behavior: