Updates Dimforge dependencies and API usage#20
Open
JulianRuiseco wants to merge 2 commits into
Open
Conversation
- Migrate from `Qbvh` to `Bvh` for spatial partitioning in `PoissonLayer`. - Implement coordinate conversion helpers between `nalgebra` and `parry` types. - Update `Aabb` and `TriMesh` usage to match new `parry` APIs.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fslabs-bot
Bot
added
the
size/L
Contributor
|
This PR doesn’t look very good. It’s switching to glam in only a few places and converts to nalgebra everywhere else. A proper migration should switch to glam everywhere other than when we need higher-dimensional features. |
Author
|
@sebcrozet Yeah. Agree. It was a dead minimum change to get stuff compiling. Happy to drop it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
nalgebrato 0.34,nalgebra-sparseto 0.11, andparry3d-f64to 0.26.This update includes significant changes to adapt to the new API of
parryandnalgebra:parry::partitioning::Qbvhtoparry::partitioning::Bvh,nalgebra's newconvert-glam030feature and built-in converters for more explicit and streamlined conversions betweennalgebraandparrygeometric types.extents().max_element()and the newintersect_aabbiterator pattern.or_default()forHashMapentries.