Skip to content

SRO/ZO: Add footer to SR and ZZZ #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nguyentvan7 merged 4 commits into from
Mar 9, 2025
Merged

SRO/ZO: Add footer to SR and ZZZ #2833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2083ab7
Show commit hash in header for dev mode
nguyentvan7 Mar 9, 2025
1ea7681
Revert "Show commit hash in header for dev mode"
nguyentvan7 Mar 9, 2025
e264b55
Add footer to zzz and sr
nguyentvan7 Mar 9, 2025
1c4a75a
Update strings
nguyentvan7 Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/sr-frontend/src/app/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
} from '@mui/material'
import { Suspense, lazy } from 'react'
import { HashRouter, Route, Routes } from 'react-router-dom'
import Footer from './Footer'
import Header from './Header'
import PageHome from './PageHome'

Expand Down Expand Up @@ -83,6 +84,9 @@ function Content() {
</Routes>
</Suspense>
</Container>
{/* make sure footer is always at bottom */}
<Box flexGrow={1} />
<Footer />
</Box>
)
}
45 changes: 45 additions & 0 deletions apps/sr-frontend/src/app/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import { AppBar, Box, Skeleton, Typography } from '@mui/material'
import { Suspense } from 'react'

export default function Footer() {
return (
<Suspense fallback={<Skeleton variant="rectangular" height={64} />}>
<FooterContent />
</Suspense>
)
}
function FooterContent() {
return (
<AppBar
component="footer"
position="static"
sx={{ bgcolor: 'neutral800.main' }}
elevation={0}
>
<Box
display="flex"
justifyContent="space-between"
sx={{ px: 2, py: 1 }}
gap={2}
>
<Typography variant="caption" sx={{ color: 'neutral400.main' }}>
Build:
<a
href={
process.env.NX_URL_GITHUB_GO_CURRENT_VERSION ||
`${process.env.NX_URL_GITHUB_GO}/releases`
}
target="_blank"
rel="noreferrer"
style={{ color: 'inherit' }}
>
{process.env.NX_URL_GITHUB_GO_CURRENT_VERSION?.replace(
/.*commit\//,
''
).substring(0, 7)}
</a>
</Typography>
</Box>
</AppBar>
)
}
4 changes: 4 additions & 0 deletions apps/zzz-frontend/src/app/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
import { Suspense, lazy } from 'react'
import { HashRouter, Route, Routes } from 'react-router-dom'
import '../styles.scss'
import Footer from './Footer'
import Header from './Header'
const PageDiscs = lazy(() => import('@genshin-optimizer/zzz/page-discs'))
const PageOptimize = lazy(() => import('@genshin-optimizer/zzz/page-optimize'))
Expand Down Expand Up @@ -78,6 +79,9 @@ function Content() {
</Routes>
</Suspense>
</Container>
{/* make sure footer is always at bottom */}
<Box flexGrow={1} />
<Footer />
</Box>
)
}
45 changes: 45 additions & 0 deletions apps/zzz-frontend/src/app/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import { AppBar, Box, Skeleton, Typography } from '@mui/material'
import { Suspense } from 'react'

export default function Footer() {
return (
<Suspense fallback={<Skeleton variant="rectangular" height={64} />}>
<FooterContent />
</Suspense>
)
}
function FooterContent() {
return (
<AppBar
component="footer"
position="static"
sx={{ bgcolor: 'neutral800.main' }}
elevation={0}
>
<Box
display="flex"
justifyContent="space-between"
sx={{ px: 2, py: 1 }}
gap={2}
>
<Typography variant="caption" sx={{ color: 'neutral400.main' }}>
Build:
<a
href={
process.env.NX_URL_GITHUB_GO_CURRENT_VERSION ||
`${process.env.NX_URL_GITHUB_GO}/releases`
}
target="_blank"
rel="noreferrer"
style={{ color: 'inherit' }}
>
{process.env.NX_URL_GITHUB_GO_CURRENT_VERSION?.replace(
/.*commit\//,
''
).substring(0, 7)}
</a>
</Typography>
</Box>
</AppBar>
)
}