ZO: Add a roadmap to home page#2725
Conversation
WalkthroughThe pull request expands the GitHub Actions workflows to include steps that create a Changes
Sequence Diagram(s)sequenceDiagram
participant CI as GitHub Actions
participant Build as Build Process
participant FE as Frontend Setup
CI->>Build: Trigger build workflow for frontend
Build->>FE: Execute setup for .env.local (existing & new for zzz-frontend)
FE-->>Build: Environment files created
Build-->>CI: Build process completes
sequenceDiagram
participant UI as PageHome Component
participant RM as Roadmap Component
participant ZC as ZCard (PatchNotesCard)
UI->>RM: Render Roadmap component
UI->>ZC: Render PatchNotesCard with updated API URL
RM-->>UI: Display roadmap milestones
ZC-->>UI: Display patch notes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[sr-frontend] [Wed Feb 12 21:03:24 UTC 2025] - Deployed d31ba01 to https://genshin-optimizer-prs.github.io/pr/2725/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Feb 12 21:03:44 UTC 2025] - Deployed d31ba01 to https://genshin-optimizer-prs.github.io/pr/2725/frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Wed Feb 12 21:04:18 UTC 2025] - Deployed d31ba01 to https://genshin-optimizer-prs.github.io/pr/2725/zzz-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Feb 12 22:04:38 UTC 2025] - Deployed d31ba01 to https://genshin-optimizer-prs.github.io/pr/2725/sr-frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Wed Feb 12 22:04:46 UTC 2025] - Deployed d31ba01 to https://genshin-optimizer-prs.github.io/pr/2725/zzz-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Feb 12 22:05:14 UTC 2025] - Deployed d31ba01 to https://genshin-optimizer-prs.github.io/pr/2725/frontend (Takes 3-5 minutes after this completes to be available) [Wed Feb 12 22:30:59 UTC 2025] - Deleted deployment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libs/zzz/page-home/src/Roadmap.tsx (1)
12-180: Accessibility is on point! But we need i18n... sips more coffeeLove the aria-labels for emojis and the structured hierarchy! However, all the text is hardcoded in English. We should move these strings to translation files.
Let's wrap the text content with translation components. Here's an example for the first milestone:
- Roadmap to ZZZero-maxxing + {t('roadmap.title')}Also, consider extracting milestone data to a separate configuration file for better maintainability:
// roadmap.config.ts export const milestones = [ { id: 1, titleKey: 'roadmap.milestone1.title', status: 'completed', descriptionKey: 'roadmap.milestone1.description', tasks: [ { key: 'roadmap.milestone1.tasks.datamine' }, // ... more tasks ] }, // ... more milestones ];
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/build-frontend.yml(1 hunks).github/workflows/build-new-release.yml(1 hunks)apps/zzz-frontend/.env(1 hunks)libs/zzz/page-home/src/Roadmap.tsx(1 hunks)libs/zzz/page-home/src/index.tsx(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- apps/zzz-frontend/.env
🔇 Additional comments (4)
libs/zzz/page-home/src/index.tsx (2)
14-19: Layout structure looks clean! yawnsThe Stack component with consistent spacing creates a nice vertical rhythm. The ZCard wrapper adds a nice touch of consistency with the design system.
29-29: Hold up... environment variable name changed! ☕️The API URL environment variable has changed from
NX_URL_GITHUB_API_ZZZ_RELEASEStoNX_URL_GITHUB_API_GO_RELEASES. Let's make sure this is updated everywhere.✅ Verification successful
🏁 Script executed:
#!/bin/bash # Check for any remaining references to the old env var rg "NX_URL_GITHUB_API_ZZZ_RELEASES"Length of output: 35
Verified: Environment variable update is complete with no lingering references to the old variable.
- Confirmed the usage in
libs/zzz/page-home/src/index.tsxnow correctly usesprocess.env['NX_URL_GITHUB_API_GO_RELEASES'].- The search for
NX_URL_GITHUB_API_ZZZ_RELEASESreturned no results, indicating all instances have been updated..github/workflows/build-new-release.yml (1)
42-42: Looks good! stretchesThe addition of .env.local for zzz-frontend aligns with the existing pattern. Nice and consistent!
.github/workflows/build-frontend.yml (1)
63-63: Another .env setup... consistent! yawns againThe .env.local setup for zzz-frontend matches the pattern in build-new-release.yml. Good consistency across workflows!
2 participants
Describe your changes
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.Summary by CodeRabbit