Change PR deployment to build artifact + deploy#1576
Merged
Conversation
frzyc
previously approved these changes
Feb 29, 2024
frzyc
left a comment
Owner
There was a problem hiding this comment.
LGTM, looks like it works on your own repo as well. One minor nit.
eeeqeee
reviewed
Feb 29, 2024
Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com>
frzyc
approved these changes
Feb 29, 2024
RobberToe
added a commit
to RobberToe/genshin-optimizer
that referenced
this pull request
Mar 13, 2024
This reverts commit af59815.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
pull_requesteventpull_request_target.masterbranch, so a developer cannot hijack our pipeline.Issue or discord link
Testing/validation
Tested on my own repo nguyentvan7#27
Deployment succeeded, comment appeared as expected. We won't be able to test the fork-based capabilities until this is merged into the main repo. But at the very least, it is not a regression for non-fork branches.
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.