patches

[grimreaper]

I thought I had push access to help with some cleanup & bug fixes - but meh

[bdrewery]

You previously committed this, but I reverted it. A user could easily incorrectly create /etc/portmaster.rc file and be confused why it doesn't work.

[grimreaper]

Then the error message should be changed. Most tools don't check for random files which happen to have the same name as their config file. Why not check in /usr/local/lib/portmasterrc ?

[bdrewery]

That's just silly.

[grimreaper]

Exactly. I see no reason to retain the check for /etc/portmaster.rc; why not 'find / -name portmaster.rc' or 'locate portmaster.rc'
Most tools don't contain extra code to check for irrelevant files and I think the check here is mostly useless given that this support was removed 3 years ago.

That said, this mostly a pointless argument.

[bdrewery]

Portmaster is one of the first tools new users will encounter when coming to FreeBSD. The /usr/local/etc is very different than what they are likely used to. They are still likely to place a portmaster.rc file in /etc. It's completely disingenuous to suggest the user may put it into /usr/local/lib or $RANDOM_PLACE. There is absolutely 0 benefit to removing this check and >0 benefit to keeping it.