tds: return None instead of "NULL" string for SQL NULL values#2185
Open
n3rada wants to merge 1 commit into
Open
tds: return None instead of "NULL" string for SQL NULL values#2185n3rada wants to merge 1 commit into
n3rada wants to merge 1 commit into
Conversation
parseRow() and TDS_SSVARIANT._parseValue() returned the string "NULL" for SQL NULL values. This is semantically wrong: downstream code cannot distinguish a genuine NULL from a column that literally contains the text "NULL", and standard Python idioms like `if value is None` or `value or default` do not work. Replace every `value = "NULL"` / `return "NULL"` with `None`. Update processColMeta() and printRows() to format None as the string "NULL" for display output, preserving the existing table rendering.
Contributor
Author
|
What is your opinion about this one @gabrielg5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseRow() and TDS_SSVARIANT._parseValue() returned the string "NULL" for SQL NULL values. This is semantically wrong: downstream code cannot distinguish a genuine NULL from a column that literally contains the text "NULL", and standard Python idioms like
if value is Noneorvalue or defaultdo not work.Replace every
value = "NULL"/return "NULL"withNone. Update processColMeta() and printRows() to format None as the string "NULL" for display output, preserving the existing table rendering.