Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #64 +/- ##
==========================================
Coverage 97.34% 97.35%
+ Complexity 965 964 -1
==========================================
Files 123 123
Lines 5357 5370 +13
==========================================
+ Hits 5215 5228 +13
Misses 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nside a filesystem transaction
* develop: add extensive CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filesystem proofs fail because in the previous major release to relied on an implicit feature of the in memory filesystem that has been changed since then. The bug was present on a concrete filesystem but was unnoticed before now.
The problem lies with the fact that the
notCommitedadapter doesn't keep track of deleted files/directories. So when applying the directories to thecommitedadapter it fails to apply removals.Todo: