feat: implement granular pitch shifter#729
Conversation
- Added `grainPitchShift` parameter (-36 to +36 st) to `SamplerBankParams` and `Note` interfaces. - Implemented core DSP in `rubberband-processor.ts` to shift pitch independently of tempo tracking via `Math.pow(2.0, grainPitchShift / 12.0)`. - Updated `SingingVoice.ts` and `useAudioEngine.ts` to push global and per-step automation overrides to the worklet. - Added UI controls (Knob and Slider) to `SamplerPanel.tsx` and `NoteSelector.tsx`. - Ignored compiled JS/WASM outputs in .gitignore and cleaned from index. - Updated `agent_plan.md` to track progress and added new vocoder idea. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
This PR implements the Granular Pitch Shifter, fulfilling an idea from the Innovation Lab.
It introduces a new
grainPitchShiftparameter that operates within therubberband-processorAudioWorklet. This parameter independently modulates the pitch scale (-36 to +36 semitones) on top of the base pitch tracking, enabling advanced granular smearing and crystalline synthesis effects.Changes
pitchMultiplierbased ongrainPitchShiftin the Web Audio worklet.SamplerBankParams,Noteoverrides,SingingVoice.ts, anduseAudioEngine.ts.SamplerPanel.tsxand a Slider inNoteSelector.tsxfor automation.public/*.js,public/*.wasm,src/wasm/outputs to.gitignoreand removed accidentally tracked artifacts to clean up the diff. Updatedagent_plan.mdto check off the task and add a new architectural goal.Tests have been updated and are passing.
PR created automatically by Jules for task 3393911044770456537 started by @ford442